Fix plotting error when a track only has a single state #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by squeeze removing extra dimension when only a single state was present. Using concatenate along correct dimension avoids this.
sdhiscocks
requested review from
nperree-dstl and
hpritchett-dstl
and removed request for
a team
Codecov ReportBase: 94.66% // Head: 94.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 171 171
Lines 8773 8773
Branches 1707 1707
=======================================
Hits 8305 8305
Misses 342 342
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
gawebb-dstl
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Looks good to me. I tested it with this snippet of code
from stonesoup.plotter import Plotter
from stonesoup.types.track import Track
from stonesoup.types.state import State
import matplotlib.pyplot as plt
t1 = Track([State([1,2]),
State([2,4])])
t2 = Track([State([1,4])])
plotter = Plotter()
plotter.plot_tracks(t1, mapping=[0,1])
try:
plotter.plot_tracks(t2, mapping=[0, 1])
print("Pass")
except IndexError:
print("Fail")
plt.show()
jswright-dstl
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by squeeze removing extra dimension when only a single state was present. Using concatenate along correct dimension avoids this.